Call to simple setter from within class

Reports calls to a simple property setter from within the property's class.

A simple property setter is defined as one which simply assigns the value of its parameter to a field, and does no other calculations. Such simple setter calls can be safely inlined. Some coding standards also suggest against the use of simple setters for code clarity reasons.

Example:

  class Foo {
  private int index;
    public Foo(int idx) {
       setIndex(idx);
    }
    public void setIndex(int idx) {
       index = idx;
    }
  }

After the quick-fix is applied:

  class Foo {
    private int index;
    public Foo(int idx) {
      index = idx;
    }
    public void setIndex(int idx) {
      index = idx;
    }
  }

Locating this inspection

By ID

Can be used to locate inspection in e.g. Qodana configuration files, where you can quickly enable or disable it, or adjust its settings.

CallToSimpleSetterFromWithinClass

Via Settings dialog

Path to the inspection settings via IntelliJ Platform IDE Settings dialog, when you need to adjust inspection settings directly from your IDE.

Settings or Preferences | Editor | Inspections | Java | Performance

Use the following options to configure the inspection:

Whether to only report setter calls on this, not on objects of the same type passed in as a parameter.
Whether to ignore non-private setters.

Inspection options

Here you can find the description of settings available for the Call to simple setter from within class inspection, and the reference of their default values.

Ignore setter calls on other objects: Not selected
Only report when setter is 'private': Not selected

Inspection Details
By default bundled with:	IntelliJ IDEA 2024.2, Qodana for JVM 2024.2,
Can be installed with plugin:	Java, 242.22892

Last modified: 11 September 2024