Call to 'Connection.prepare*()' with non-constant string

Reports calls to java.sql.Connection.prepareStatement(), java.sql.Connection.prepareCall(), or any of their variants which take a dynamically-constructed string as the statement to prepare.

Constructed SQL statements are a common source of security breaches. By default, this inspection ignores compile-time constants.

Example:

  String bar() { return "bar"; }

  Connection connection = DriverManager.getConnection("", "", "");
  connection.("SELECT * FROM user WHERE name='" + bar() + "'");

Locating this inspection

By ID

Can be used to locate inspection in e.g. Qodana configuration files, where you can quickly enable or disable it, or adjust its settings.

JDBCPrepareStatementWithNonConstantString

Via Settings dialog

Path to the inspection settings via IntelliJ Platform IDE Settings dialog, when you need to adjust inspection settings directly from your IDE.

Settings or Preferences | Editor | Inspections | Java | Security

Use the inspection settings to consider any static final fields as constants. Be careful, because strings like the following will be ignored when the option is enabled:

  static final String SQL = "SELECT * FROM user WHERE name='" + getUserInput() + "'";

Inspection options

Here you can find the description of settings available for the Call to 'Connection.prepare*()' with non-constant string inspection, and the reference of their default values.

Consider 'static final' fields constant: Not selected

Availability

By default bundled with: IntelliJ IDEA 2024.1, Qodana for JVM 2024.1,
Can be installed with plugin: Java, 241.18072

Last modified: 18 June 2024