Non-constant string concatenation as argument to logging call
Reports non-constant string concatenations that are used as arguments to SLF4J and Log4j 2 logging methods. Non-constant concatenations are evaluated at runtime even when the logging message is not logged; this can negatively impact performance. It is recommended to use a parameterized log message instead, which will not be evaluated when logging is disabled.
Example:
public class Vital {
private static final Logger LOG = LoggerFactory.getLogger(Vital.class);
public void saveTheWorld(int i, String s, boolean b) {
LOG.info("saveTheWorld(" + i + ", " + s + ", " + b + ")");
// todo
}
}
After the quick-fix is applied:
public class Vital {
private static final Logger LOG = LoggerFactory.getLogger(Vital.class);
public void saveTheWorld(int i, String s, boolean b) {
LOG.info("saveTheWorld({}, {}, {})", i, s, b);
// todo
}
}
- By ID
Can be used to locate inspection in e.g. Qodana configuration files, where you can quickly enable or disable it, or adjust its settings.
StringConcatenationArgumentToLogCall
Configure the inspection:
Use the Warn on list to ignore certain higher logging levels. Higher logging levels may be enabled even in production, and the arguments will always be evaluated.
Here you can find the description of settings available for the Non-constant string concatenation as argument to logging call inspection, and the reference of their default values.
Inspection Details | |
---|---|
By default bundled with: | |
Can be installed with plugin: | Java, 243.23126 |
Thanks for your feedback!