Java
'instanceof' check for 'this'
Warning
New
Last modified: 03 December 2024 Reports usages of instanceof
or getClass() == SomeClass.class
in which a this
expression is checked.
Such expressions indicate a failure of the object-oriented design, and should be replaced by polymorphic constructions.
Example:
class Super {
void process() {
if (this instanceof Sub) { // warning
doSomething();
} else {
doSomethingElse();
}
}
}
class Sub extends Super {}
To fix the problem, use an overriding method:
class Super {
void process() {
doSomethingElse();
}
}
class Sub extends Super {
@Override
void process() {
doSomething();
}
}
- By ID
Can be used to locate inspection in e.g. Qodana configuration files, where you can quickly enable or disable it, or adjust its settings.
InstanceofThis
Inspection Details | |
---|---|
By default bundled with: | |
Can be installed with plugin: | Java, 243.23126 |
Thanks for your feedback!
Was this page helpful?