Upsource 2017.1 Help

Roles in code reviewReviewing your teammate's changes

Requesting a code review

As someone who requests code review from your teammates, you typically perform the following sequence of tasks:

  1. Commit changes to your VCS repository.
  2. Create a code review.
  3. Invite participants (reviewers and optionally watchers).
  4. Discuss issues, if any, by way of exchanging comments with the reviewer(s).
  5. Work on resolving the issues, commit the fixes, and add the new revision(s) to the existing review.
  6. As soon as reviewers approve your changes, you close the review.

While committing changes is self-explanatory, we'll describe the other steps below.

Create a code review

  1. Log into Upsource and locate your project in the list:
    Project list
  2. Click on the project name to open it. The project home view displays the revisions listed in chronological order:
    CR_revList.png
  3. Scroll down the list or use the Search field to find the revision you're interested in.
  4. Move your cursor to the revision entry — a Create review link will appear:
    Project list
  5. Click Create review. A new review is created, opened, and its ID is displayed at the top left (JD-CR-27 in our case):
    CR_revCreate.png

The default review title is the same as your revision which becomes a part of this review.

To change the review title, click the Edit icon Edit icon next to it.

Invite participants

Add participants to the reviewers or watchers list depending on the action you want them to take.

To add a reviewer or a watcher

  1. Open the review and under the Overview tab click the plus sign next to the corresponding heading.
  2. Select the name from the pop-up list:
    CR_pickReviewer.png

Upsource might suggest you the most suitable reviewers (based on previous assignments) which you can select without opening the reviewer selection pop-up.

You can also add watchers while posting a comment: just type @ in the text field and the same list will appear.

You can add as many participants as you wish and whenever you wish: when starting a review, or at any time after that.

The people you add are notified via e-mail and Upsource news feed.

To remove a participant, click their userpic in the Reviewers area and confirm the deletion:

Remove participant

Participate in discussion

You can post comments, addressing them to other participants, and reply to the comments left by reviewers.

There are three types of comments:

  • Review comment is not tied up to any particular file or part of code — its subject matter may be anything within the scope of the review.
  • Code selection comment is intended to pinpoint a particular code fragment in one of the files being reviewed.
  • Line comment is associated with a specific line of code.

Review comment is not tied up to any particular file or part of code — its subject matter may be anything within the scope of the review.

CR_genComment.png

To post a line comment

  1. Select the desired file to display the inline diff:
    CR_click_file_for_diff.png
  2. Select the line you want to comment on by clicking the edit icon to the left:
    Add line comment
  3. Enter your message in the text box and click Add comment:
    Add line comment

To post a code selection comment:

  1. Select the desired file and go Side-by-side diff or View file.
  2. Select the lines you want to discuss and choose Comment on selection from the pop-up menu.
  3. Type in your message and click Add Comment
    CR_comMenu.png

Posted code selection comments and line comments are embedded in code and highlighted with yellow.

CR_inlineComment.png

When a discussion thread comes to a logical end, either you or the reviewer can mark it as resolved.

Review progress

A progress bar underneath a reviewer's avatar will give you a hint on each reviewer's progress. Hover over it to see how many files out of those included with the review the reviewer has already opened.

review_progress.png

Review resolution

When reviewers accept or raise concern about your changes, their resolution is indicated with a corresponding flag:

CR_accept_reject

Add new revisions

If the revision you had originally submitted for review was not approved by the reviewers, you can work on the issues, commit fixes, and attach one or several new revisions to the original review for approval.

This way the whole discussion and revision history is contained within one review, and as long as the review is open it will always be visible throughout the different revisions.

You can attach a new revision to an existing review either from that revision:

CR_attachToReview.png

or from the review:

CR_addRevision.png

To detach a revision from a review, in the review home view, click the Detach icon next to the revision name:

Detach from review

Open a review in IDE

When you click this link, the review and the revisions it includes will be displayed in a separate tab of the Review tool window of your currently opened IDEA-based IDE. For this option to work, the IDE should have the Upsource plug-in installed and configured and the project should be open in the IDE.

CR_open_in_IDE

Close review

As soon as all reviewers have approved your changes, and you expect no further input, you can close the review by clicking a corresponding button in the right pane:

Close review

Review status

A review can go through three different stages:

  1. Pending — review is created and reviewers assigned.
  2. Completed — all reviewers completed the review by raising concern about or accepting your changes.
  3. Closed — review is closed by its author, as no further action is required or expected from all participants.

Remove review

Whether you've created a review by mistake, or want to clean up and get rid of outdated reviews, you can always delete a review no matter what its current status is.

Click the Edit icon Edit icon next to the review title:

CR_click_edit_title

Then push the Remove review button.

CR_remove_review.png
Last modified: 13 July 2017